SSerguey Asael Shinder
Java coding notes: the JVM, and writing software that lasts

Serguey Asael Shinder: A fix in the repository is not a fix on the machine where the bug runs

· by Serguey Asael Shinder / Serguey Shinder

A review posted on the Polkadot forum on 6 November traces how code that sent Fearless Wallet users' keys to an attacker lived in public source for about 16 months. It arrived in a 251-file pull request labelled as TON support, with no review comments, and it was deleted on 25 June 2026 inside a release commit of around 80,000 changed lines. The detail that stays with me is in the last section: according to the project's own notice, installed copies of versions 3.0.3 to 3.0.5 still contain the code, and it could be switched on again through the remote configuration it reads. (https://forum.polkadot.network/t/fearless-wallet-key-leak-16-months-in-public-code-and-the-review-checks-that-catch-it/19279)

That is the gap between two meanings of fixed. In the repository, the bug is fixed when the commit lands. For a user, it is fixed when the code running on their machine no longer contains it. Between the two sit a release, a distribution channel and a decision by the user or their device to install the update. Any of them can fail quietly, and none of them shows up in the issue tracker.

Serguey Asael Shinder: A fix in the repository is not a fix on the machine where the bug runs
A fix in the repository is not a fix on the machine where the bug runs — Serguey Asael Shinder

Server software has the same gap in a quieter form. A vulnerable library can be patched on the main branch and the ticket closed while a service that has not been redeployed keeps running the old jar. A dashboard that tracks merged pull requests stays green, because it measures the code and not the fleet.

The practical rule is to define done by the place where the bug runs. For a server, that means checking what version is deployed, not what is merged. For a client application or an extension, it means a minimum supported version, enforced where possible, and an honest message telling users to update or remove the old one. And for anything security-related, the work is not finished until someone has counted how many installations are still on the bad version.

A merge is the start of a fix. It is the easiest part to measure, which is why it is so often mistaken for the end.